Make Weixin launch scripts portable on Windows - #23
Draft
lxy375718307 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
tsxentrypoint.node.exeandcodex.exefromPATHinstead of hard-coding user- and version-specific executable paths.%USERPROFILE%\Documentsas the portable default working directory..codexbridgedirectory.Why
The previous launch scripts depended on one developer's npm-installed Codex command and absolute document path. Those assumptions fail on Codex desktop installations and on other Windows user profiles.
Impact
Windows users can launch Weixin login and serving with the local project dependencies while retaining the option to override Node, Codex, locale, transport, and working-directory settings through environment variables.
Validation
git diff --checkwhere node.exeandwhere codex.exeresolve successfully fromcmd.exenpm.cmd run typecheckwas attempted; it remains blocked by pre-existingcodex-provider-relayexample and test type errors unrelated to these batch scripts